Make the fallback value bytes in getbit() #154

dsalisbury · 2017-07-03T13:35:54Z

Make the fallback value bytes in getbit() otherwise byte_to_int() will go bang if getbit(key, n) is called before setbit(key, n, v)

Specifically, I have a test which fails due to this:

b = '\x00'

    def byte_to_int(b):
        if isinstance(b, int):
            return b
>       raise TypeError('an integer is required')
E       TypeError: an integer is required

...otherwise byte_to_int() will go bang if getbit(key, n) is called before setbit(key, n, v)

bmerry · 2017-11-10T08:36:17Z

This is also handled by #166.

bmerry · 2017-11-10T13:18:43Z

I've created a fork called fakenewsredis with a PyPI release to incorporate PRs that aren't getting traction here. I've included #166 (which supersedes this one) there.

bmerry · 2018-03-22T14:46:38Z

Closing because #166 has been merged into 0.10.1 (via the fakenewsredis fork).

getbit: fallback value needs to be bytes

2c56028

...otherwise byte_to_int() will go bang if getbit(key, n) is called before setbit(key, n, v)

jamesls added the NeedsTests label Oct 12, 2017

bmerry closed this Mar 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make the fallback value bytes in getbit() #154

Make the fallback value bytes in getbit() #154

dsalisbury commented Jul 3, 2017 •

edited

Loading

bmerry commented Nov 10, 2017

bmerry commented Nov 10, 2017

bmerry commented Mar 22, 2018

Make the fallback value bytes in getbit() #154

Make the fallback value bytes in getbit() #154

Conversation

dsalisbury commented Jul 3, 2017 • edited Loading

bmerry commented Nov 10, 2017

bmerry commented Nov 10, 2017

bmerry commented Mar 22, 2018

dsalisbury commented Jul 3, 2017 •

edited

Loading